Dsv4 fix#1232
Open
LiJunscs wants to merge 7 commits into
Open
Conversation
LiJunscs
requested review from
aoyulong,
heavyrain-lzy and
zhaoyinglia
as code owners
…_moe_parallel_comm. 2. remove useless assert in arguments. 3. add a config for dsv4 ci test file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Category
[Train]
PR Types
[Bug Fixes]
PR Description
Fix the precision error compared to the Megatron-LM caused by the data type of moe_act_func and mhc recompute.
Associated with flagos-ai/Megatron-LM-FL#73
Result as follows:
